New Installer plugins bugs#10296
Conversation
| (452, 'plg_system_updatenotification', 'plugin', 'updatenotification', 'system', 0, 1, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0), | ||
| (453, 'plg_editors-xtd_module', 'plugin', 'module', 'editors-xtd', 0, 1, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0), | ||
| (454, 'plg_system_stats', 'plugin', 'stats', 'system', 0, 1, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0), | ||
| (455, 'plg_installer_packageinstaller', 'plugin', 'packageinstaller', 'installer', 0, 1, 1, 1, '{"name":"plg_installer_packageinstaller","type":"plugin","creationDate":"07.05.2016","author":"Joomla","copyright":"Copyright (C) 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"www.joomla.org","version":"1.0","description":"PLG_PACKAGE_INSTALLER_PLUGIN_XML_DESCRIPTION","group":"","filename":"packageinstaller"}', '{}', '', '', 0, '0000-00-00 00:00:00', 1, 0), |
There was a problem hiding this comment.
Actually, the manifest cache's should be removed in full from the joomla.sql files (we populate them in the install app the same way they get refreshed on updates, so this is just extra static cruft that can be forgotten about).
We purposefully took them out a couple years ago for that reason (and the fact that we were having to set the CMS version number in here too on every bump).
There was a problem hiding this comment.
Joomla refresh the manifest on install? Didn't know that. Nice.
To be clear, you're talking just about the {"name":"plg_installer_packageinstaller","type":"plugin","creationDate":"07.05.2016","author":"Joomla","copyright":"Copyright (C) 2016 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"www.joomla.org","version":"1.0","description":"PLG_PACKAGE_INSTALLER_PLUGIN_XML_DESCRIPTION","group":"","filename":"packageinstaller"} part, not the all SQL, right?
There was a problem hiding this comment.
Right. The manifest_cache field's contents shouldn't be included in the SQL files.
And right here in the installer is where the magic is happening. Just before the magic that apparently language distro's can use is processed.
There was a problem hiding this comment.
thanks! just updated this PR to remove the manifest cache
|
I have tested this item ✅ successfully on d6fd8e5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10296. |
|
@andrepereiradasilva We are working on the same thing. PLT actually decided to split the url/folder installer in two separate ones. There will be merge conflicts so I propose I merge your changes into the code I am writing. |
|
Closing here as @roland-d will merge this directly into his own PR This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10296. |
|
ok then. |
Pull Request for New Issue.
Summary of Changes
This PR solves some more issues that began with c52e0d2
Testing Instructions
Code review.