Skip to content

[Regression] Readded stuff from #10190#10281

Merged
wilsonge merged 5 commits intojoomla:stagingfrom
bembelimen:Menu_ACL
May 8, 2016
Merged

[Regression] Readded stuff from #10190#10281
wilsonge merged 5 commits intojoomla:stagingfrom
bembelimen:Menu_ACL

Conversation

@bembelimen
Copy link
Copy Markdown
Contributor

@bembelimen bembelimen commented May 7, 2016

Pull Request for Issue #9814

Summary of Changes

Add batch check again

Testing Instructions

Apply patch => Choose "All menu items" => check batch

@bembelimen bembelimen changed the title Readded stuff from #10190 [Regression] Readded stuff from #10190 May 7, 2016
@infograf768
Copy link
Copy Markdown
Member

Please take care of formatting in the batchcopy regression.
Spaces instead of tabs
I also have indented after the conditional in my original PR

Same changes to the batchfooter.
@infograf768
Copy link
Copy Markdown
Member

@bembelimen
Can you merge
bembelimen#5 as we also need the correct code for the footer

@infograf768
Copy link
Copy Markdown
Member

BTW, Travis error has nothing to do with this PR.

Update default_batch_footer.php
@bembelimen
Copy link
Copy Markdown
Contributor Author

Thanks @infograf768

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 6dc2515


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10281.

@infograf768
Copy link
Copy Markdown
Member

rtc, as this a regression.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10281.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@infograf768
Copy link
Copy Markdown
Member

please add milstone to 3.6.0 and merge. thanks

@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 8, 2016
@wilsonge wilsonge merged commit 6d714c5 into joomla:staging May 8, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants