Skip to content

[com_finder] filter view (new/edit): Use language title in language subbranch#10267

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:com_finder_filter_languages
May 7, 2016
Merged

[com_finder] filter view (new/edit): Use language title in language subbranch#10267
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:com_finder_filter_languages

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented May 6, 2016

Summary of Changes

As done in #10266 for the content maps list, this PR adds the language title (instead of code and *) to the new/edit filter view.

Also removed some duplicated query instructions.

Before Patch

image

After patch

image

Testing Instructions

Note that for this test you have to have index in the Smart Search (com_finder) in multiple langauges and the system language plugin disabled.

  1. Apply patch
  2. Check the Language subbranches in Components -> Smart Search -> Search Filter, and then the "New" button

The languages titles should be exactly the same you have in Extensions -> Languages -> Content Languages.

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 2357213


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10267.

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 7, 2016

I have tested this item ✅ successfully on 2357213

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10267.

@infograf768
Copy link
Copy Markdown
Member

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10267.

@joomla-cms-bot joomla-cms-bot changed the title [com_finder] filter view (new/edit): Use language title in language subbranch [com_finder] filter view (new/edit): Use language title in language subbranch May 7, 2016
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 7, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 7, 2016
@wilsonge wilsonge merged commit 2bd680e into joomla:staging May 7, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

thanks all for testing and comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants