Skip to content

[4.0] query re colours used for highlighting differences in original and overridden files #36330

@Scrabble96

Description

@Scrabble96

Problem identified

I have just updated a J4 site from 4.0.4 to 4.0.5 and have been notified of four overridden files.
One of these is a category blog override and I'm currently looking at blog_children.php.

Having double-checked with the source code here on Github, I can see that:

The copyright appears to have changed from
"* @copyright Copyright (C) 2005 - 2020 Open Source Matters, Inc. All rights reserved."
to
" * @copyright (C) 2010 Open Source Matters, Inc. https://www.joomla.org"

file-override-differences

and line 32 from
<span class="badge badge-info tip">
to
<span class="badge bg-info tip">

(Plus a few other changes).

I would have expected the new, 'correct' text or code to be highlighted green and the old, or 'wrong' text or code that needs changing, to be highlighted in pink.

Similarly, above the editor, in order to see the original file file, you have to click the grey button that says "Hide Original" and to see the differences, click the grey button "Hide Differences"

Proposed solution

  1. Swap the highlighting colours
  2. Switch the text so that it initially displays "Show Original" and "Show Differences"

Open questions

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions