Skip to content

B/C fix - Modules (including core) using the "cache" XML parameter always cached, regardless of that parameter's value #24917

@fevangelou

Description

@fevangelou

Steps to reproduce the issue

Many Joomla core modules (e.g. mod_menu, mod_custom etc.) as well as lots of third-party modules still use "cache" as the de-facto XML parameter to allow for a module to be cached along with the rest of Joomla's rendered content (when Joomla caching is set to "on") or excluded from Joomla's cache overall.

The current check in JModuleHelper::moduleCache() is currently invalid (checks for the newer "owncache" XML parameter twice).

See pull request #24916 for the simple fix.

Expected result

When Joomla's cache is enabled, most core modules with caching set to "no" (usually under the Advanced tab in their parameters) and probably the vast majority of third-party modules are always cached. This should not happen.

Actual result

System information (as much as possible)

Additional comments

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions