Eliminate unnecessary duplication#102
Conversation
Squiz.WhiteSpace.CastSpacingSniff sniff in currently included as a file but is exactly identical to the source. Thus include the rule set and delete the duplicated file.
This file is exactly identical to the source, delete the file and add the standard to the rule set
- replaces redundant file
|
I've updated description of #104 several times, so make sure you've addressed all sniffs. |
For removals related to PHPCS-2 development branch see PR #101 |
|
Nice catch with these task checkboxes that GitHub have. Would be much easier to track now. |
- Set PSR2.ControlStructures.ElseIfDeclaration to an error rather than a warning
|
@mbabker Do you think it would be better to break this PR up into multiple PRs for each file removal and rule inclusion pair? currently it would be about 7 PRs with consideration for 3 others. |
|
Truthfully, it doesn't matter much to me. As long as I (or someone) can make sense of it all when sitting down to go through it; if it's clearly explained somewhere I'm not too picky about it being one PR. |
|
@mbabker My thought was it might be easier for you (or someone) to sit down and look at each one individually and approve one here and there; rather than the larger time commitment to review as one big PR. But taking your advice for this to be "clearly explained somewhere," I have updated the PR description to cover the intent and current inclusions of this PR. |
|
@mbabker shall we finish this 1.x PR or close in favor of "leaving the 1.x structure in a "minimal maintenance" type of state." ? |
|
Ya, let's just leave things alone. The whole "if it ain't broke" thing. Better for us to put our code focus on the 2.x ruleset at this point. |
Since the following files are identical to the source; include the rule set and delete the duplicated file.