Skip to content

CMS Adapter removed#301

Merged
HLeithner merged 2 commits intojoomla:mainfrom
Hackwar:adapter-removed
Sep 1, 2025
Merged

CMS Adapter removed#301
HLeithner merged 2 commits intojoomla:mainfrom
Hackwar:adapter-removed

Conversation

@Hackwar
Copy link
Copy Markdown
Member

@Hackwar Hackwar commented Aug 24, 2024 •
edited by qodo-code-review bot
Loading

User description

This is the documentation PR for joomla/joomla-cms#43792, joomla/joomla-cms#43793 and joomla/joomla-cms#43794

PR Type

documentation

Description

  • Added documentation for the removal of the CMS Adapter classes in the Joomla CMS.
  • Included a reference to the relevant PR and described the changes.
  • Noted that the classes \Joomla\CMS\Adapter\Adapter and \Joomla\CMS\Adapter\AdapterInstance have been removed without replacement.

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document removal of CMS Adapter classes                                   

migrations/54-60/removed-backward-incompatibility.md

  • Added documentation for the removal of CMS Adapter classes.
  • Provided a PR reference for the changes.
  • Explained that the classes \Joomla\CMS\Adapter\Adapter and
    \Joomla\CMS\Adapter\AdapterInstance have been removed without
    replacement.
    		•  +5/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @qodo-code-review qodo-code-review bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Aug 24, 2024
    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Aug 24, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Typo
    There is a typo in the header "CMS Adapter classes have been remoed". It should be "removed" instead of "remoed".

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Aug 24, 2024 •
    edited
    Loading

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Fix a typographical error in the heading

    Correct the typo in the heading from "remoed" to "removed" to improve readability
    and professionalism of the documentation.

    migrations/54-60/removed-backward-incompatibility.md [26]

    -### CMS Adapter classes have been remoed
+### CMS Adapter classes have been removed
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Correcting the typo from "remoed" to "removed" is important for maintaining professionalism and clarity in documentation, making it a valuable improvement.

    		9
    Best practice
    Provide more detailed information about the impact and migration steps for removed classes

    Add information about potential impact and migration steps for users who might be
    using the removed CMS Adapter classes to provide more comprehensive guidance.

    migrations/54-60/removed-backward-incompatibility.md [28-29]

     - PR: https://github.com/joomla/joomla-cms/pull/43794
 - Description: The classes `\Joomla\CMS\Adapter\Adapter` and `\Joomla\CMS\Adapter\AdapterInstance` have been removed without replacement.
+- Impact: Extensions or custom code using these classes will need to be refactored.
+- Migration: Consider implementing your own adapter pattern or refactor code to use alternative design patterns.
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding information about the impact and migration steps enhances the documentation by providing users with guidance on how to handle the removal of classes, though it is not critical, it improves comprehensiveness.

    		7

    This was referenced Aug 24, 2024
    Merged
    Merged
    Merged
    @HLeithner HLeithner added the 6.0 PR for Joomla 6.0 label Oct 19, 2024
    @HLeithner HLeithner merged commit 478fa62 into joomla:main Sep 1, 2025
    1 check was pending
    @Hackwar Hackwar deleted the adapter-removed branch September 1, 2025 10:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    6.0 PR for Joomla 6.0 documentation Improvements or additions to documentation Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @Hackwar @HLeithner