Map keys control+s to save command on forms by dgrammatiko · Pull Request #55 · joomla/40-backend-template

dgrammatiko · 2016-10-12T20:39:08Z

Pull Request for Issue # .

Summary of Changes

Added one more layout for toolbar apply button
Added needed code in core.js to support mapping key press to save

Testing Instructions

Documentation Changes Required

C-Lodder · 2016-10-15T15:59:48Z

Could u please test on windows @DGT41.

Just tested and it's not working

zero-24 · 2016-10-15T16:07:30Z

libraries/cms/toolbar/button/apply.php

+	 *
+	 * @return  string   JavaScript command string
+	 *
+	 * @since   3.0


3.0 ? Should this not be __DEPLOY_VERSION__ or 4.0?

wilsonge · 2016-10-15T16:09:04Z

Doesn't work for me on macbook either

dgrammatiko · 2016-10-15T16:53:15Z

For mac is command+s

By the way which view did you try? (article edit)

C-Lodder · 2016-10-15T16:56:31Z

yes i did that (george here) - it tried to save html contents of the page. i did also read your js :P

dgrammatiko · 2016-10-15T16:58:59Z

media/system/js/core.js

+	// Initiate the listener for the combo key
+	document.addEventListener( 'DOMContentLoaded', function() {
+		if (Joomla.getOptions( 'keySave' ) ) {
+			Joomla.keysave( Joomla.getOptions( 'keySave' ).task );


can you insert a console.log(Joomla.getOptions( 'keySave' ).task); before this line?
what it is in the console?

article.apply

dgrammatiko · 2016-10-15T17:10:42Z

media/system/js/core.js

+			if (e.keyCode == 83 && (navigator.platform.match("Mac") ? e.metaKey : e.ctrlKey)) {
+				e.preventDefault();
+				Joomla.submitbutton.call(button)
+			}


Joomla.submitbutton(button);

@C-Lodder try with the above code

C-Lodder · 2016-10-15T17:18:53Z

Ok I know the issue now.

You can't be focused on the editor when using CTRL + S. You need to click outside the editor for it to work.

This only happens with TinyMCE.

dgrammatiko · 2016-10-15T17:20:50Z

media/system/js/core.js

+	 */
+	Joomla.keysave = function ( button ) {
+		document.addEventListener("keydown", function(e) {
+			if (e.keyCode == 83 && (navigator.platform.match("Mac") ? e.metaKey : e.ctrlKey)) {


add a console.log(''pressed: ' + e.keyCode + ' and ' + e.ctrlKey );
What happens when you press keys?

or try

if (String.fromCharCode(e.which).toLowerCase() == 's' && (navigator.platform.match("Mac") ? e.metaKey : e.ctrlKey)) {

British keyboards, I guess your s is mapped to some other keyCode 😄

C-Lodder · 2016-10-15T17:23:07Z

Tiny mce loads in an iframe so i guess the iframe doesn't load the keybindings (george)

dgrammatiko · 2016-10-15T17:29:35Z

Ahh, crap, I didn;t try it with focus in tiny window (?)

C-Lodder · 2016-10-15T17:34:00Z

xD

dgrammatiko · 2016-10-15T17:34:27Z

solution here: http://stackoverflow.com/questions/5732370/make-tinymcejeditable-submit-after-pressing-ctrls

C-Lodder · 2016-10-15T17:41:46Z

layouts/joomla/toolbar/apply.php

+}
+else
+{
+	JHtml::_('behavior.core');


behaviour core is being loaded in the if and the else can we just load it outside the if and then remove the else?

wilsonge · 2016-10-16T10:54:36Z

Go for it then :)

C-Lodder · 2016-10-17T10:55:41Z

@DGT41 - Forget the research, already solved it:

tinymce-init.js (line 62 directly above tinyMCE.init(options);), add the following:

options.plugins = 'save';
options.toolbar = 'save';
options.save_onsavecallback = function() { Joomla.submitbutton('article.apply'); }

This is the only bit of code you need, so you can revert all the other changes you've made.

dgrammatiko · 2016-10-17T12:14:13Z

The only problem is that article.apply will work only in articles, so it needs something more...

dgrammatiko · 2016-10-17T18:39:13Z

last commit:

remove tiny close script (mootools modal thingy)
make tinyMCE init script vanilla
add support for ctrl+s

NOTE: if you haven't change anything in the editor area (no new text, etc) the save will not initiate!

With this ctrl+s works on all editors that comes with Joomla

C-Lodder · 2016-10-19T08:56:52Z

All working now :)

control-s

808a1fd

zero-24 reviewed Oct 15, 2016

View reviewed changes

dgrammatiko commented Oct 15, 2016

View reviewed changes

Dimitri Grammatikogianni added 2 commits October 15, 2016 20:11

Update core.js

93af5a4

Update apply.php

57be6d4

dgrammatiko commented Oct 15, 2016

View reviewed changes

C-Lodder reviewed Oct 15, 2016

View reviewed changes

Update apply.php

c486144

fix tinyMCE

8e58ab9

C-Lodder merged commit 4d5740f into joomla:master Oct 19, 2016

dgrammatiko deleted the control-s branch November 2, 2016 13:46

dgrammatiko mentioned this pull request Feb 17, 2018

[4.0][RFC] Custom Element: Joomla! Toolbar button joomla/joomla-cms#19635

Closed

dgrammatiko mentioned this pull request Mar 10, 2019

[4.0] Shortcut Keys joomla/joomla-cms#24152

Closed

Conversation

dgrammatiko commented Oct 12, 2016

Summary of Changes

Testing Instructions

Documentation Changes Required

Uh oh!

C-Lodder commented Oct 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilsonge commented Oct 15, 2016

Uh oh!

dgrammatiko commented Oct 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C-Lodder commented Oct 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Oct 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

C-Lodder commented Oct 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

C-Lodder commented Oct 15, 2016

Uh oh!

dgrammatiko commented Oct 15, 2016

Uh oh!

C-Lodder commented Oct 15, 2016

Uh oh!

dgrammatiko commented Oct 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilsonge commented Oct 16, 2016

Uh oh!

C-Lodder commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgrammatiko commented Oct 17, 2016

Uh oh!

dgrammatiko commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C-Lodder commented Oct 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dgrammatiko commented Oct 15, 2016 •

edited

Loading

dgrammatiko Oct 15, 2016 •

edited

Loading

C-Lodder commented Oct 17, 2016 •

edited

Loading

dgrammatiko commented Oct 17, 2016 •

edited

Loading