ReaderHighlight: Highlight menu, change 'Delete' to Trash can icon#1
Merged
Conversation
Discussed in koreader#12754
Frenzie
reviewed
Nov 20, 2024
| { | ||
| { | ||
| text = _("Delete"), | ||
| text = ("\u{F48E}"), -- Trash can (icon to prevent confusion of Delete/Details buttons) |
There was a problem hiding this comment.
Suggested change
| text = ("\u{F48E}"), -- Trash can (icon to prevent confusion of Delete/Details buttons) | |
| text = "\u{F48E}", -- Trash can (icon to prevent confusion of Delete/Details buttons) |
Owner
Author
There was a problem hiding this comment.
Thanks. Oops, I already merged it, I'll try do it it right, this time.
|
I was a bit confused about various things not working but you made a PR to your own repo ;-) |
Owner
Author
|
Yes I just realized that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes koreader#12754; as discussed there.
Other icons or text labels would also be okay, this is only to prevent user confusion of the easily mixed up Details/Delete buttons.