Upgrade to quick-xml 0.27#282
Closed
jonhoo wants to merge 1 commit into
Closed
Conversation
Note that since we have `pub` functions that return `quick_xml` types, this would be a breaking change. Interestingly enough, we only expose `quick_xml` in the form of `quick_xml::Result` as far as I can tell. Specifically, we're using its error type, which feels like something we can avoid to mitigate this kind of "transitive bump" in the future. In particular, I think we could reasonable start using an opaque error type for these methods instead.
Codecov ReportBase: 91.17% // Head: 91.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 91.17% 91.15% -0.02%
==========================================
Files 19 19
Lines 4237 4242 +5
==========================================
+ Hits 3863 3867 +4
- Misses 374 375 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
Owner
Author
|
Closing in favor of #325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that since we have
pubfunctions that returnquick_xmltypes, this would be a breaking change.Interestingly enough, we only expose
quick_xmlin the form ofquick_xml::Resultas far as I can tell. Specifically, we're using its error type, which feels like something we can avoid to mitigate this kind of "transitive bump" in the future. In particular, I think we could reasonable start using an opaque error type for these methods instead.Marking this as a draft so we don't merge it without intending to do a major release.