Eliminate dependency on serde's "derive" feature#694
Merged
jonasbb merged 1 commit intojonasbb:masterfrom Feb 8, 2024
Merged
Conversation
This was referenced Feb 8, 2024
Contributor
Author
|
CI failures look unrelated to this change. See #695. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 65.41% 65.41%
=======================================
Files 38 38
Lines 2322 2322
=======================================
Hits 1519 1519
Misses 803 803 ☔ View full report in Codecov by Sentry. |
Owner
|
Thank you for the PRs. This looks ok, but I think it re-introduces the risk of mismatching serde dependency versions. Bumping the serde dependency to v1.0.186 should mitigate this. I can bump the dependency and release a new patch version. |
Contributor
Author
|
Thank you, that would be great. Yes, serde 1.0.186+ contains serde-rs/serde#2588 which eliminates the version mismatch possibility. |
Owner
|
v3.6.1 is published now |
This was referenced Jun 4, 2025
Revert the suggestion to use the
derive feature instead of serde_derive directly
serde-rs/serde#2584
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows serde, and other crates downstream of it like serde_json, to compile in parallel with serde_derive. Without this PR, in any dependency graph that pulls in serde_with, first serde_derive would need to compile, then serde would need to compile, then serde_json would need to compile.
sharkdp/bat#2815 has a diagram of the impact of this change.