Initialise struct timezone in main_add_changes_commit#1291
Merged
koutcher merged 1 commit intojonas:masterfrom Aug 31, 2023
Merged
Initialise struct timezone in main_add_changes_commit#1291koutcher merged 1 commit intojonas:masterfrom
koutcher merged 1 commit intojonas:masterfrom
Conversation
On musl libc gettimeofday (which is used by time_now) does not populate the timezone struct passed to it as POSIX says: > If tzp is not a null pointer, the behavior is unspecified. tz_minuteswest is later multiplied by 60 which can overflow. When tig is compiled with integer overflow hardening (as is done on Chimera Linux) via the clang option -fsanitize=signed-integer-overflow this can result in tig crashing due to the overflow.
Collaborator
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On musl libc
gettimeofday(which is used by time_now) does not populate the timezone struct passed to it as POSIX says:tz_minuteswest is later multiplied by 60 which can overflow (if the value that happens to be in
tz_minuteswestis large). When tig is compiled with integer overflow hardening (as is done on Chimera Linux) via the clang option-fsanitize=signed-integer-overflowthis can result in tig crashing due to the overflow.This PR initialises
tzto prevent this.