Follow-up to #2287: Add requested tests (#2358)

patakk · just6660 · web-flow · commit 6fa5e2876653 · 2026-04-06T11:34:29.000-05:00
* Fix: Ensure deterministic locale selection in multi-locale mode * Add missing tests for PR #2287 don't increase any version part. --------- Co-authored-by: just6660 <just6660@gmail.com>
diff --git a/faker/proxy.py b/faker/proxy.py
@@ -11,7 +11,7 @@
 from .config import DEFAULT_LOCALE
 from .exceptions import UniquenessException
 from .factory import Factory
-from .generator import Generator, random
+from .generator import Generator
 from .typing import SeedType
 from .utils.distribution import choices_distribution
 
diff --git a/tests/test_proxy.py b/tests/test_proxy.py
@@ -437,6 +437,43 @@ def test_dir_include_all_providers_attribute_in_list(self):
         attributes = dir(fake)
         assert attributes == expected
 
+    def test_select_factory_distribution_uses_instance_random(self):
+        from faker.utils.distribution import choices_distribution
+
+        locale = OrderedDict([("de_DE", 3), ("en_US", 2), ("ja_JP", 5)])
+        fake = Faker(locale)
+        fake.seed_instance(12345)
+
+        instance_random = fake._factories[0].random
+        with patch("faker.proxy.choices_distribution", wraps=choices_distribution) as mock_dist:
+            fake.name()
+            mock_dist.assert_called_once()
+            args = mock_dist.call_args[0]
+            assert args[2] is instance_random
+
+    def test_seed_instance_deterministic_multi_locale_no_weights(self):
+        fake = Faker(["en_US", "ja_JP", "de_DE"])
+        fake.seed_instance(12345)
+        first_run = [fake.name() for _ in range(20)]
+
+        fake2 = Faker(["en_US", "ja_JP", "de_DE"])
+        fake2.seed_instance(12345)
+        second_run = [fake2.name() for _ in range(20)]
+
+        assert first_run == second_run
+
+    def test_seed_instance_deterministic_multi_locale_with_weights(self):
+        locale = OrderedDict([("de_DE", 3), ("en_US", 2), ("ja_JP", 5)])
+        fake = Faker(locale)
+        fake.seed_instance(12345)
+        first_run = [fake.name() for _ in range(20)]
+
+        fake2 = Faker(locale)
+        fake2.seed_instance(12345)
+        second_run = [fake2.name() for _ in range(20)]
+
+        assert first_run == second_run
+
     def test_copy(self):
         fake = Faker("it_IT")
         fake2 = copy.deepcopy(fake)
