check that email match field is not empty before running email check on new user registrations#2
Closed
philscott-rg wants to merge 1 commit intojoho1968:masterfrom
Conversation
…on new user registrations This fixes a case where new user registration can become inadvertently disabled if: - The `Banned usernames` field has a value - The `Email must match` field is empty This results in: - The `fail2wp_admin_check_new_user` filter will be applied at l.422, because of the `Banned usernames` value - The email match check starting at l.1039 will always be run regardless of the field value, and defaults to invalid - The email match will always return invalid because there is no value to match against - New user registrations are then effectively disabled, as all emails are found to be invalid
Owner
|
Implemented for next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a case where new user registration can become inadvertently disabled if:
Banned usernamesfield has a valueEmail must matchfield is emptyThis results in:
fail2wp_admin_check_new_userfilter will be applied at l.422, because of theBanned usernamesvalue