Fix GitHub actions#10
Fix GitHub actions#10johnmai-dev merged 4 commits intohuggingface:mainfrom DePasqualeOrg:fix-github-actions
Conversation
|
Now this works. Regarding the formatting rules: Would you mind if we remove |
|
I added the same pre-commit hook as in mlx-swift, so that you can run the following command to format before committing: |
You can remove it. |
|
Okay, I think this is ready to go. |
|
@johnmai-dev, once you're able to merge this, I'll rebase my previous PR to make it easier for @pcuenca to review it. |
johnmai-dev
left a comment
There was a problem hiding this comment.
Thanks for the fix!
| - name: Select Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app | ||
|
|
There was a problem hiding this comment.
Maybe remove Select Xcode? Previously, it was needed to specify xcode for version 5.8. @DePasqualeOrg
The current GitHub actions appear to be failing, maybe because they include Swift 5.8. I also included a swift-format step.