Skip to content

app: Idle-inhibit when window is fullscreen#1557

Merged
johnfactotum merged 1 commit intojohnfactotum:gtk4from
agx:inhibit
Sep 23, 2025
Merged

app: Idle-inhibit when window is fullscreen#1557
johnfactotum merged 1 commit intojohnfactotum:gtk4from
agx:inhibit

Conversation

@agx
Copy link
Contributor

@agx agx commented Jul 27, 2025

When reading in fullscreen one usually doesn't want the session to go idle (thus dim the screen and eventually blank it).

With this reading on mobile is a breeze, without it I'd have to remember to turn on/off "caffeine" mode.

Edit: I'm not much of JS person so please excuse if this doesn't look very JS-like.

@agx agx force-pushed the inhibit branch 2 times, most recently from e648c72 to 37b1eee Compare September 12, 2025 20:43
@agx
Copy link
Contributor Author

agx commented Sep 12, 2025

eslint looks mostly happy now, I'd just need a hint what to do about the _pspec unused variable.

@johnfactotum
Copy link
Owner

You can just leave it out. Or if you feel like it, make it a comment. So like

win => {

or

(win/*, _pspec*/) => {

But probably just leave it out. I don't think I've ever used the spec when connecting to signals.

When reading in fullscreen one usually doesn't want the session
to go idle (thus dim the screen and eventually blank it).

With this reading on mobile is a breeze, without it I'd have to
remember to turn on/off "caffeine" mode.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
@agx
Copy link
Contributor Author

agx commented Sep 23, 2025

Let's just drop it then, thanks.

@johnfactotum johnfactotum merged commit d9185a7 into johnfactotum:gtk4 Sep 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants