Conversation
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
@tomMoral ok for merging those code cleanups? I think they bring general improvements to the code base (and remove deprecation warnings for distutils in the tests). |
|
Note that there are some things that will get reformatted by the switch to black but many things are actual small code changes that generally improve the code and make it more modern now that we don't need to be compatible with Python 2 syntax and older Python 3 versions. |
tomMoral
left a comment
There was a problem hiding this comment.
There are a few changes that seems arbitrary and make the code less explicit in my opinion but overall, this makes the code much cleaner so merging this one.
|
Thanks a lot @arquolo for all the hard work!!! and @glemaitre and @ogrisel for splitting the changes in smaller PR. |
|
Nice. This was a big PR :) |
This PRs picks up all the remaining code cleanups from #304 except the one on the
reduction.pymodule. I prefer to make this module preserve its public API to keep it consistent with the upstream multiprocessing reduction API.I also merge master to resolve a few conflicts.
Fixes #303.