[MRG] Refactor test_logger.py as per pytest design.#453
[MRG] Refactor test_logger.py as per pytest design.#453lesteve merged 1 commit intojoblib:masterfrom
Conversation
|
@lesteve This was a small module ! Merging this PR would be easier and faster than previous ones I guess 😄 |
d7712f5 to
07e8585
Compare
|
LGTM, merging thanks! Thanks also for doing the pytest migration in chunks, this helps the review process a lot!
|
|
Wohoo that was really quick ! Well I realize that I am not letting you rest, but I'm enjoying this, we are nearing completion 🎉 |
It's nice indeed when something is progressing that quickly so we want to keep the momentum going. Having said that your last PRs are clearly an outlier (on the low side) in terms of PR reviewing time. I can not guarantee that it will be like this for the rest of times, so enjoy it while it lasts ;-). |
Third Phase PR on #411 (Succeeding PR #450)
This PR deals with refactor of tests in test_logger.py to adopt the pytest flavor.
There is one only test method, which used a temporary file to log output. The setup and teardown for the same, using
tempfilemodule has been removed, and instead, pytest's owntmpdirfixture is specified as function parameter.Instead of raising an AssertionError based on condition, direct usage of
assertkeyword is used.