FIX Close cleanly distributed Client at the end of unit tests#1526
Merged
ogrisel merged 2 commits intojoblib:masterfrom Dec 1, 2023
Merged
FIX Close cleanly distributed Client at the end of unit tests#1526ogrisel merged 2 commits intojoblib:masterfrom
ogrisel merged 2 commits intojoblib:masterfrom
Conversation
1a5194e to
dfd29c4
Compare
ogrisel
reviewed
Nov 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
- Coverage 95.06% 95.06% -0.01%
==========================================
Files 44 44
Lines 7564 7562 -2
==========================================
- Hits 7191 7189 -2
Misses 373 373 ☔ View full report in Codecov by Sentry. |
ogrisel
approved these changes
Dec 1, 2023
Contributor
ogrisel
left a comment
There was a problem hiding this comment.
Thanks very much. The test logs look much cleaner now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distributed pipeline seemed to be less stable after #1520 , all tests do pass and there is no deadlock but the python interpreter terminates with an error code and outputs a long traceback related to backend termination.
This PR might help fix that, it ensures that when a distributed.Client is opened locally in unit tests, it is also closed cleanly before exiting the test (like it has always been done in https://github.com/joblib/joblib/blob/master/joblib/test/test_dask.py but was overlooked in https://github.com/joblib/joblib/blob/master/joblib/test/test_parallel.py )