Skip to content

MAINT: Update byte_bounds import#1501

Merged
ogrisel merged 4 commits intojoblib:masterfrom
mtsokol:update-byte-bounds-import
Aug 29, 2023
Merged

MAINT: Update byte_bounds import#1501
ogrisel merged 4 commits intojoblib:masterfrom
mtsokol:update-byte-bounds-import

Conversation

@mtsokol
Copy link
Copy Markdown
Contributor

@mtsokol mtsokol commented Aug 28, 2023

This PR addresses changes introduced in numpy/numpy#24540 and numpy/numpy#24376 relevant to NEP 52.

@mtsokol mtsokol force-pushed the update-byte-bounds-import branch from f047bb6 to e4ed146 Compare August 28, 2023 11:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.57% ⚠️

Comparison is base (abd3af7) 94.86% compared to head (68f909d) 94.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   94.86%   94.29%   -0.57%     
==========================================
  Files          45       45              
  Lines        7515     7519       +4     
==========================================
- Hits         7129     7090      -39     
- Misses        386      429      +43
Files Changed Coverage Δ
joblib/_memmapping_reducer.py 94.88% <100.00%> (-1.52%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsokol mtsokol mentioned this pull request Aug 28, 2023
Merged
@mtsokol mtsokol force-pushed the update-byte-bounds-import branch from e4ed146 to de8fb1a Compare August 28, 2023 11:46
rgommers
rgommers approved these changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the unlikely event that someone is going to complain about the array_utils name and we end up changing it in numpy's main branch, the code can be updated. This should be safe to merge now.

ogrisel
ogrisel reviewed Aug 29, 2023
View reviewed changes
Comment thread joblib/_memmapping_reducer.py
@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Aug 29, 2023

Thanks, could you please just update the changelog to make it explicit that the next joblib release targets numpy 2.0 compat?

@mtsokol
Copy link
Copy Markdown
Contributor Author

mtsokol commented Aug 29, 2023

Thanks, could you please just update the changelog to make it explicit that the next joblib release targets numpy 2.0 compat?

Sure! I added it.

@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Aug 29, 2023

The CI failure is weird but unrelated to this PR.

@ogrisel ogrisel merged commit d6d70ea into joblib:master Aug 29, 2023
@mtsokol mtsokol deleted the update-byte-bounds-import branch August 29, 2023 13:19
@apiszcz apiszcz mentioned this pull request Mar 8, 2024
Closed
@lesteve lesteve mentioned this pull request Feb 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel approved these changes

+1 more reviewer

@rgommers rgommers rgommers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtsokol @ogrisel @rgommers