DOC: Best randomness with Parallel generators#1490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.02%
==========================================
Files 45 45
Lines 7491 7491
==========================================
+ Hits 7103 7105 +2
+ Misses 388 386 -2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
The deadlock in the shutdown of the The read the docs failure seems unrelated as well: but it's unfortunate because I would have liked the updated example in this PR to be executed on readthedocs before merging. |
ogrisel
left a comment
There was a problem hiding this comment.
It did run successfully in the previous iteration though:
https://readthedocs.org/projects/joblib/builds/22563643/
Let's merge.
|
Thanks @paquiteau! |
Hi,
I found a small imprecision in the parallel random state example 1, as using iterative seed is not recommended as per 2. This PR update the example to the best practice, and add a reference to the Numpy documentation for the curious reader.
Footnotes
https://joblib.readthedocs.io/en/latest/auto_examples/parallel_random_state.html#sphx-glr-auto-examples-parallel-random-state-py ↩
https://numpy.org/doc/stable/reference/random/parallel.html#sequence-of-integer-seeds ↩