Skip to content

DOC add public documentation for parallel_backend#1481

Merged
tomMoral merged 5 commits intojoblib:masterfrom
glemaitre:fix_doc_parallel_backend
Jul 10, 2023
Merged

DOC add public documentation for parallel_backend#1481
tomMoral merged 5 commits intojoblib:masterfrom
glemaitre:fix_doc_parallel_backend

Conversation

@glemaitre
Copy link
Copy Markdown
Contributor

I see some intersphinx warnings in scikit-learn. I assume that the reason is that the documentation is not exposed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (3c314c1) 94.86% compared to head (45e767e) 94.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   94.86%   94.75%   -0.11%     
==========================================
  Files          45       45              
  Lines        7474     7474              
==========================================
- Hits         7090     7082       -8     
- Misses        384      392       +8     
Impacted Files Coverage Δ
joblib/parallel.py 96.90% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GaelVaroquaux
Copy link
Copy Markdown
Member

I guess that for these reasons (intersphinx warnings) we should expose parallel_backend in our documentation. Our thinking was that we want to move users away from it.

@tomMoral : do you approve?

Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the goal was to make it clear it was not supposed to be used anymore.
But indeed, for these reason we should keep it in the doc.

Can you simply move it to a new deprecated subsection at the end of the references?

@glemaitre
Copy link
Copy Markdown
Contributor Author

Yep, I can do that.

Currently all our docstring in scikit-learn are the following:

n_jobsint, default=None
    The number of jobs to run in parallel.
    None means 1 unless in a joblib.parallel_backend context.
    -1 means using all processors.

So I assume that we should replace it by joblib.parallel_config?

@GaelVaroquaux
Copy link
Copy Markdown
Member

GaelVaroquaux commented Jul 6, 2023 via email

@glemaitre
Copy link
Copy Markdown
Contributor Author

I slightly change the template of the navigation bar to make it explicit which part is deprecated.

I also add a more obvious warning in parallel_backend.

Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @glemaitre

@tomMoral tomMoral merged commit 8be8d32 into joblib:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants