FIX treat n_jobs=None as if left to its default value#1475
FIX treat n_jobs=None as if left to its default value#1475tomMoral merged 10 commits intojoblib:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1475 +/- ##
==========================================
- Coverage 94.94% 94.88% -0.06%
==========================================
Files 45 45
Lines 7474 7491 +17
==========================================
+ Hits 7096 7108 +12
- Misses 378 383 +5
☔ View full report in Codecov by Sentry. |
tomMoral
left a comment
There was a problem hiding this comment.
Indeed, thanks for the PR.
|
It's not fully fixed yet, i'm still working out some details |
|
Yes it is not fixed, it seems like we need to manage and test when |
tomMoral
left a comment
There was a problem hiding this comment.
Better fix indeed! thanks @jeremiedbb 😁
just an extra nom regression test.
|
Actually, |
tomMoral
left a comment
There was a problem hiding this comment.
LGTM, thx @jeremiedbb
I was quite surprised by the behavior of setting None in the context but indeed, if this is what was enforced, I think it is a good idea to keep the same behavior.
Fixes #1473
Even if the new default value of
n_jobsis a sentinel object, I think that we should not interpretn_jobs=Noneas explicitely set because it used to mean 'unset'. Instead we should treat it identically as if it were left to its default value.