Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (b9be27d) 94.82% compared to head (b502da5) 94.83%.

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
+ Coverage   94.82%   94.83%   +0.01%     
==========================================
  Files          45       45              
  Lines        7474     7474              
==========================================
+ Hits         7087     7088       +1     
+ Misses        387      386       -1     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomMoral will this also perchance fix the error I was seeing:

on windows python 3.7:

File "C:\Miniconda\envs\test\lib\site-packages\joblib\externals\loky\backend\popen_loky_win32.py", line 153, in main
_winapi.SYNCHRONIZE | _winapi.PROCESS_DUP_HANDLE, False, parent_pid
AttributeError: module '_winapi' has no attribute 'SYNCHRONIZE'

that was also an issue that appeared with python 3.7, windows platform and joblib 1.3.0 release.

No, it will not.
Sorry I missed this point in the issue.

This is complicated as we did many changes in loky to support python3.10/11 as I think we had some bad interaction with handle sharing, due to the fact we were not using the SYNCHRONIZE key word. So I am not sure if we can mitigate this easily.
Could you please open an issue on loky with this problem reported? Maybe we can simply hard code the value of SYNCHRONIZE on 3.7 but we need to test this and as this is touchy code, it might take a little while.

In the meantime, as this PR already improve the compact support for other plateforms using 3.7, I will first release this.

@tomMoral thanks I've created a new issue here:
joblib/loky#411
as you suggested