Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 94.91% 94.82% -0.10%
==========================================
Files 44 44
Lines 7439 7439
==========================================
- Hits 7061 7054 -7
- Misses 378 385 +7
☔ View full report in Codecov by Sentry. |
ogrisel
approved these changes
Jun 27, 2023
Contributor
ogrisel
left a comment
There was a problem hiding this comment.
Nice trick, thanks for the PR!
Contributor
|
The scikit-learn failures are unrelated, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
joblibmaintainers!thank you for your hard work. I came here because a useful warning had a typo in it, "..loaded from the file redacted is not not bytes aligned." and noticed that there was another instance of a
not nottypo elsewhere in the repository. Unsatisfied to fix just those two "not not" instances, I decided to regex for others, and here's the result.For the record, the incantation I used was
git grep -E "\b(\w+)\s+\1\b"and the few remaining results for this are legitimate ("Matrix Matrix multiplication", for example).Happy hacking!