Skip to content

Document parallel_config#1451

Merged
GaelVaroquaux merged 2 commits intojoblib:masterfrom
GaelVaroquaux:parallel_config_doc
Jun 21, 2023
Merged

Document parallel_config#1451
GaelVaroquaux merged 2 commits intojoblib:masterfrom
GaelVaroquaux:parallel_config_doc

Conversation

@GaelVaroquaux
Copy link
Copy Markdown
Member

@GaelVaroquaux GaelVaroquaux commented Jun 9, 2023

It seems that parallel_config was not very visible in the docs.

This is a quick fix to improve a bit the situation.

We should probably adapt more our docs, but I only have a little bit of time.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (f6aaaa6) 94.88% compared to head (b7c8b81) 94.78%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   94.88%   94.78%   -0.10%     
==========================================
  Files          44       44              
  Lines        7366     7366              
==========================================
- Hits         6989     6982       -7     
- Misses        377      384       +7

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomMoral
Copy link
Copy Markdown
Contributor

tomMoral commented Jun 21, 2023

the failing doc build should be fixed by #1456
could you retriever the build?

@GaelVaroquaux GaelVaroquaux merged commit 9f7edc2 into joblib:master Jun 21, 2023
@GaelVaroquaux
Copy link
Copy Markdown
Member Author

GaelVaroquaux commented Jun 21, 2023

the failing doc build should be fixed by #1456 could you retriever the build?

Sorry, I made a mistake with the web interface trying to merge main in this PR, and did the opposite. I hope that it is fine.

1 similar comment
@GaelVaroquaux
Copy link
Copy Markdown
Member Author

GaelVaroquaux commented Jun 21, 2023

the failing doc build should be fixed by #1456 could you retriever the build?

Sorry, I made a mistake with the web interface trying to merge main in this PR, and did the opposite. I hope that it is fine.

@tomMoral
Copy link
Copy Markdown
Contributor

tomMoral commented Jun 22, 2023

It is okay, the CI is green and the change looked okay.
I just wanted to have a look at the rendering before merging but we can still improve the doc later on if needed, so no problem.

@tomMoral tomMoral mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaelVaroquaux @tomMoral