CLN deprecate bytes_limit from Memory#1447
Merged
ogrisel merged 2 commits intojoblib:masterfrom Jun 8, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
+ Coverage 94.59% 94.75% +0.16%
==========================================
Files 44 44
Lines 7361 7366 +5
==========================================
+ Hits 6963 6980 +17
+ Misses 398 386 -12
☔ View full report in Codecov by Sentry. |
ogrisel
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter
bytes_limitfromMemoryis misleading as it makes the user believe that this will be enforced automatically, whereas the user needs to callMemory.reduce_sizeto enforce this.As this parameter can be directly passed to
Memory.reduce_size, along withitems_limitandage_limitsince #1200, I propose to deprecate it from theMemoryclass.