CLN make generator exit thread safe#1428
Merged
tomMoral merged 15 commits intojoblib:masterfrom Apr 24, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
- Coverage 94.71% 94.54% -0.17%
==========================================
Files 44 44
Lines 7205 7207 +2
==========================================
- Hits 6824 6814 -10
- Misses 381 393 +12
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ogrisel
reviewed
Apr 19, 2023
Contributor
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the follow-up!
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Contributor
|
Suggestion to add a warning when it happens for interpreters other than Pypy in tomMoral#1 |
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #1393 where we try to make the generator clean up thread safe for all interpreter, not only for Pypy.