DBG try to debug the thread_bomb_mitigation test#1424
Merged
tomMoral merged 7 commits intojoblib:masterfrom Apr 18, 2023
Merged
DBG try to debug the thread_bomb_mitigation test#1424tomMoral merged 7 commits intojoblib:masterfrom
tomMoral merged 7 commits intojoblib:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 94.76% 94.75% -0.01%
==========================================
Files 45 45
Lines 6890 6918 +28
==========================================
+ Hits 6529 6555 +26
- Misses 361 363 +2
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation PR for #1150
From the investigation, this bug seems to be related to a bad interaction between the test, Pypy and
coverage.I propose to disable the coverage on this test to stabilize the test suite.
I was able to reproduce the failure locally by running the test with
--cov=jobliband by adding the following at the beginning of the test:This could be investigated further if someone has the time to do so.