High verbosity mode that prints arguments, hash and store location.#1416
High verbosity mode that prints arguments, hash and store location.#1416tomMoral merged 7 commits intojoblib:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
- Coverage 94.87% 94.72% -0.15%
==========================================
Files 46 45 -1
Lines 6901 6918 +17
==========================================
+ Hits 6547 6553 +6
- Misses 354 365 +11
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Overall the changes seem acceptable and useful. Thanks a lot. Could you add a test that does some rough check that the added functionality works right. If we don't do this, the danger is that later changes break the functionality. Cheers |
tomMoral
left a comment
There was a problem hiding this comment.
A couple of comments but I agree this @GaelVaroquaux , this functionality is nice and is something that I have been thinking of for quite some time.
Thanks for the PR and for adding tests.
A couple of comments along the way on style.
joblib/test/test_logger.py
Outdated
| info_msg = "This is a message at logging level INFO. " | ||
| debug_msg = "This is a message at logging level DEBUG. " | ||
|
|
||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
I am unsure whether this test has border effects, as the logging API relies on global handlers.
Would it be possible to create a local handler that we remove at the end of the test?
That being said, not completely sure this test is needed, maybe we could just remove it as this tests logger functionalities that are already tested by Python?
I found this feature useful when inspecting the synchronisation of caches between a remote and local machine. In particular, it can happen that arguments are hashed differently depending on the platform.
For example, this inspection revealed that
In logging the arguments and their hash, I was able to track down and resolve those differences so that syncing the caches does now work.