MNT Use full flake8 rather than flake8_diff.sh#1415
Merged
tomMoral merged 8 commits intojoblib:masterfrom Apr 9, 2023
Merged
Conversation
tomMoral
approved these changes
Apr 8, 2023
Contributor
tomMoral
left a comment
There was a problem hiding this comment.
I think this is a nice idea so it will be easier to maintain in the long run.
A couple of comments but otherwise LGTM
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
tomMoral
reviewed
Apr 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
- Coverage 94.87% 94.78% -0.09%
==========================================
Files 46 45 -1
Lines 6901 6889 -12
==========================================
- Hits 6547 6530 -17
- Misses 354 359 +5
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tomMoral
approved these changes
Apr 9, 2023
Contributor
tomMoral
left a comment
There was a problem hiding this comment.
LGTM, the failure does not seem related.
Merging and hoping this won't cause too much troubles with other PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier to understand, easier to run locally,
flake8 --diffhas been removed inflake8>=6see #1383. There are not that many flake8 violations to fix.