BENCH add benchmark script for n_jobs=1#1400
Merged
tomMoral merged 2 commits intojoblib:masterfrom Feb 20, 2023
Merged
Conversation
Codecov ReportBase: 94.09% // Head: 94.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
- Coverage 94.09% 94.04% -0.06%
==========================================
Files 52 52
Lines 7319 7319
==========================================
- Hits 6887 6883 -4
- Misses 432 436 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This was referenced Jun 28, 2023
1 task
1 task
Merged
1 task
1 task
This was referenced Sep 7, 2023
1 task
1 task
1 task
Closed
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a benchmark script to test the overhead of calling
joblibwithn_jobs=1vs calling a sequential loop fornumpymatrix multiplications with various matrix sizes and for a very fast function (in red).This gives
here, we can see that for small tasks, we have an overhead of roughly x10 per task for tasks that takes 1ms.
This state should be corrected by the changes pushed in #588.