Skip to content

MNT Use faulthandler rather than custom autokill logic#1398

Merged
tomMoral merged 4 commits intojoblib:masterfrom
lesteve:use-faulthandler
Feb 17, 2023
Merged

MNT Use faulthandler rather than custom autokill logic#1398
tomMoral merged 4 commits intojoblib:masterfrom
lesteve:use-faulthandler

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Feb 17, 2023

This should give more information in case of deadlock.

Copy link
Copy Markdown
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming greenish CI, +1 on my side :)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2023

Codecov Report

Base: 93.88% // Head: 93.97% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (6fd7549) compared to base (7bb4b94).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   93.88%   93.97%   +0.09%     
==========================================
  Files          52       52              
  Lines        7342     7319      -23     
==========================================
- Hits         6893     6878      -15     
+ Misses        449      441       -8     
Impacted Files Coverage Δ
joblib/test/common.py 83.33% <ø> (+5.74%) ⬆️
joblib/test/test_memmapping.py 99.24% <100.00%> (-0.01%) ⬇️
joblib/memory.py 95.26% <0.00%> (-0.27%) ⬇️
joblib/_parallel_backends.py 92.27% <0.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with this comment.

Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx @lesteve

@tomMoral tomMoral merged commit 96c32ef into joblib:master Feb 17, 2023
@lesteve lesteve deleted the use-faulthandler branch February 17, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants