Skip to content

TST Close client in test_pickle_in_socket#1387

Merged
lesteve merged 2 commits intojoblib:masterfrom
lesteve:close-client-test-pickle-in-socket
Feb 15, 2023
Merged

TST Close client in test_pickle_in_socket#1387
lesteve merged 2 commits intojoblib:masterfrom
lesteve:close-client-test-pickle-in-socket

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Feb 15, 2023

I have noticed OSError: [Errno 98] Address already in use with nogil when running multiple times the following command:

pytest joblib/test/test_numpy_pickle.py -k socket
================================================ test session starts ================================================
platform linux -- Python 3.9.10, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/lesteve/dev/joblib, configfile: setup.cfg
plugins: timeout-2.1.0, forked-1.4.0, flaky-3.7.0, xdist-3.1.0
collected 130 items / 129 deselected / 1 selected                                                                   

joblib/test/test_numpy_pickle.py F                                                                            [100%]

===================================================== FAILURES ======================================================
_______________________________________________ test_pickle_in_socket _______________________________________________

    @with_numpy
    def test_pickle_in_socket():
        # test that joblib can pickle in sockets
        test_array = np.arange(10)
        _ADDR = ("localhost", 12345)
        listener = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
>       listener.bind(_ADDR)
E       OSError: [Errno 98] Address already in use

joblib/test/test_numpy_pickle.py:932: OSError
============================================== short test summary info ==============================================
FAILED joblib/test/test_numpy_pickle.py::test_pickle_in_socket - OSError: [Errno 98] Address already in use
========================================= 1 failed, 129 deselected in 0.30s =========================================
[INFO:MainProcess:MainThread] process shutting down
[DEBUG:MainProcess:MainThread] running all "atexit" finalizers with priority >= 0
[DEBUG:MainProcess:MainThread] running the remaining "atexit" finalizers

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2023

Codecov Report

Base: 94.01% // Head: 93.95% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (6f55ae1) compared to base (6836640).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
- Coverage   94.01%   93.95%   -0.06%     
==========================================
  Files          52       52              
  Lines        7300     7300              
==========================================
- Hits         6863     6859       -4     
- Misses        437      441       +4     
Impacted Files Coverage Δ
joblib/test/test_numpy_pickle.py 94.23% <100.00%> (ø)
joblib/test/testutils.py 50.00% <0.00%> (-50.00%) ⬇️
joblib/_parallel_backends.py 93.75% <0.00%> (-0.74%) ⬇️
joblib/parallel.py 96.56% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lesteve!

@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Feb 15, 2023

CI is green, merging!

@lesteve lesteve merged commit 83ba40f into joblib:master Feb 15, 2023
@lesteve lesteve deleted the close-client-test-pickle-in-socket branch February 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants