Merged
Conversation
Codecov ReportBase: 94.04% // Head: 94.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 94.04% 94.02% -0.03%
==========================================
Files 52 52
Lines 7292 7292
==========================================
- Hits 6858 6856 -2
- Misses 434 436 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
https://joblib--1348.org.readthedocs.build/en/1348/memory.html#joblib.memory.MemorizedFunc.call would have saved me a bit of confusion :) |
tomMoral
reviewed
Sep 30, 2022
Contributor
tomMoral
left a comment
There was a problem hiding this comment.
Very nice addition!
I agree that it is confusing other wise.
just a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was happy to see this method existed, but I was confused by the output not being what I expected. This adds a minimal docstring to help the next person.