Suggestion for https://github.com/scikit-learn/scikit-learn/pull/16084#8
Merged
jnothman merged 4 commits intojnothman:recodefrom Feb 22, 2020
Merged
Suggestion for https://github.com/scikit-learn/scikit-learn/pull/16084#8jnothman merged 4 commits intojnothman:recodefrom
jnothman merged 4 commits intojnothman:recodefrom
Conversation
Owner
|
Nice! Will look a bit more later. Thanks
|
jnothman
reviewed
Feb 16, 2020
Owner
jnothman
left a comment
There was a problem hiding this comment.
I like this, but the control flow becomes quite hard to read, and it may be hard for the reader to understand why the postprocessing should be outside of parse_arff (so that could deserve a comment).
Do you think we can tweak it so that it looks like:
if as_frame:
def parse_arff(...):
....
return frame,
def postprocess(frame):
....
return X, y, nominal_attributes
else:
def parse_arff(...):
....
return X, y, nominal_attributes
def postrprocess(X, y, nominal_attributes):
....
return X, y, nominal_attributes
out = _retry_with_clean_cache(url, data_home)(
_load_arff_response)(url, data_home,
return_type=return_type,
encode_nominal=not as_frame,
parse_arff=parse_arff)
X, y, nominal_attributes = postprocess(*out)
return Bunch(...)?
Author
|
Updated PR with the approach you suggested |
jnothman
approved these changes
Feb 22, 2020
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was thinking of this.
CC: @jnothman