Add method name check for generic methods Expectations#712
Open
Saljack wants to merge 1 commit intojmockit:masterfrom
Open
Add method name check for generic methods Expectations#712Saljack wants to merge 1 commit intojmockit:masterfrom
Saljack wants to merge 1 commit intojmockit:masterfrom
Conversation
a79bb44 to
c7b56e0
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #708 #700 . WIth debuging I found that there is completly missing a check for a method name. Adding this check resolves issues with generic result types. See added unit tests.