DeterministicScheduler: Future is done if cancelled#237
Merged
Conversation
The Javadoc for Future implies that `isDone()` is always true if `isCancelled()` is true. ``` Returns true if this task completed. Completion may be due to normal termination, an exception, or cancellation -- in all of these cases, this method will return true. ``` https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Future.html#isDone--
github-merge-queue Bot
referenced
this pull request
in camunda/camunda
Mar 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.jmock:jmock](http://nexus.sonatype.org/oss-repository-hosting.html) ([source](https://togithub.com/jmock-developers/jmock-library)) | `2.13.0` -> `2.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jmock-developers/jmock-library (org.jmock:jmock)</summary> ### [`v2.13.1`](https://togithub.com/jmock-developers/jmock-library/releases/tag/2.13.1) [Compare Source](https://togithub.com/jmock-developers/jmock-library/compare/2.13.0...2.13.1) Catchup on versions and PRs #### What's Changed - Update README.md by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/246](https://togithub.com/jmock-developers/jmock-library/pull/246) - Updated README instructions for using JMock in Gradle 7.0+. by [@​jbrains](https://togithub.com/jbrains) in [https://github.com/jmock-developers/jmock-library/pull/233](https://togithub.com/jmock-developers/jmock-library/pull/233) - Reduce logging by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/247](https://togithub.com/jmock-developers/jmock-library/pull/247) - Fix [#​155](https://togithub.com/jmock-developers/jmock-library/issues/155) by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/250](https://togithub.com/jmock-developers/jmock-library/pull/250) - Upgrade junit4 by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/251](https://togithub.com/jmock-developers/jmock-library/pull/251) - Bump junit.jupiter.version from 5.5.2 to 5.6.2 by [@​dependabot-preview](https://togithub.com/dependabot-preview) in [https://github.com/jmock-developers/jmock-library/pull/183](https://togithub.com/jmock-developers/jmock-library/pull/183) - Upgrade to GitHub-native Dependabot by [@​dependabot-preview](https://togithub.com/dependabot-preview) in [https://github.com/jmock-developers/jmock-library/pull/218](https://togithub.com/jmock-developers/jmock-library/pull/218) - Prepare for merge queue by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/262](https://togithub.com/jmock-developers/jmock-library/pull/262) - DeterministicScheduler: Future is done if cancelled by [@​leonz](https://togithub.com/leonz) in [https://github.com/jmock-developers/jmock-library/pull/237](https://togithub.com/jmock-developers/jmock-library/pull/237) - Bump org.apache.maven.plugins:maven-jar-plugin from 2.5 to 3.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/256](https://togithub.com/jmock-developers/jmock-library/pull/256) - Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.0.0-M2 to 3.4.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/257](https://togithub.com/jmock-developers/jmock-library/pull/257) - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.2.0 to 3.6.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/258](https://togithub.com/jmock-developers/jmock-library/pull/258) - Bump org.apache.maven.plugins:maven-failsafe-plugin from 2.22.2 to 3.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/261](https://togithub.com/jmock-developers/jmock-library/pull/261) - Dependabot ignore old junit runners by [@​olibye](https://togithub.com/olibye) in [https://github.com/jmock-developers/jmock-library/pull/263](https://togithub.com/jmock-developers/jmock-library/pull/263) - Bump net.bytebuddy:byte-buddy from 1.10.9 to 1.14.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/252](https://togithub.com/jmock-developers/jmock-library/pull/252) - Bump org.objenesis:objenesis from 3.1 to 3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/255](https://togithub.com/jmock-developers/jmock-library/pull/255) - Bump org.codehaus.mojo:versions-maven-plugin from 2.7 to 2.16.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/253](https://togithub.com/jmock-developers/jmock-library/pull/253) - Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/259](https://togithub.com/jmock-developers/jmock-library/pull/259) - Bump org.sonatype.plugins:nexus-staging-maven-plugin from 1.6.8 to 1.6.13 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/260](https://togithub.com/jmock-developers/jmock-library/pull/260) - Bump junit.jupiter.version from 5.6.2 to 5.10.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/264](https://togithub.com/jmock-developers/jmock-library/pull/264) - Bump com.thoughtworks.qdox:qdox from 2.0-M10 to 2.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/265](https://togithub.com/jmock-developers/jmock-library/pull/265) - Bump org.apache.maven.plugins:maven-surefire-plugin from 2.22.2 to 3.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/267](https://togithub.com/jmock-developers/jmock-library/pull/267) - Bump com.google.auto.service:auto-service from 1.0-rc6 to 1.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/268](https://togithub.com/jmock-developers/jmock-library/pull/268) - Bump net.alchim31.maven:scala-maven-plugin from 4.3.1 to 4.8.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/269](https://togithub.com/jmock-developers/jmock-library/pull/269) - Bump org.apache.maven.plugins:maven-gpg-plugin from 1.6 to 3.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/jmock-developers/jmock-library/pull/266](https://togithub.com/jmock-developers/jmock-library/pull/266) - Support negative delays in ScheduledFutures executed by the Determini… by [@​satur9nine](https://togithub.com/satur9nine) in [https://github.com/jmock-developers/jmock-library/pull/236](https://togithub.com/jmock-developers/jmock-library/pull/236) #### New Contributors - [@​leonz](https://togithub.com/leonz) made their first contribution in [https://github.com/jmock-developers/jmock-library/pull/237](https://togithub.com/jmock-developers/jmock-library/pull/237) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/jmock-developers/jmock-library/pull/256](https://togithub.com/jmock-developers/jmock-library/pull/256) - [@​satur9nine](https://togithub.com/satur9nine) made their first contribution in [https://github.com/jmock-developers/jmock-library/pull/236](https://togithub.com/jmock-developers/jmock-library/pull/236) **Full Changelog**: jmock-developers/jmock-library@2.13.0...2.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Javadoc for Future implies that
isDone()is always true ifisCancelled()is true.https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Future.html#isDone--