Fixed incompatibility issues failing BCR dependents#13
Conversation
|
I'm trying to verify the difference in behavior when It seems that even in the most recent release (8.2.1) the loads from $ git diff
diff --git a/MODULE.bazel b/MODULE.bazel
index 348032e..b60f435 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -5,6 +5,7 @@ module(
)
bazel_dep(name = "rules_m4", version = "0.2.3")
+bazel_dep(name = "rules_shell", version = "0.4.0", dev_dependency = True)
bazel_dep(
name = "googletest",
diff --git a/tests/BUILD b/tests/BUILD
index bb6d5aa..b392c24 100644
--- a/tests/BUILD
+++ b/tests/BUILD
@@ -1,3 +1,4 @@
+load("@rules_shell//shell:sh_test.bzl", "sh_test")
load("//flex:flex.bzl", "flex_cc_library")
cc_library(Same with a Bazel binary built at current |
|
Based on my read of bazelbuild/bazel#23043 I think this will only break once that flag is flipped or rules are not autoloaded. Both of which seem like they're scheduled for Bazel 9. I'm not sure if I think this is a patch release since it looks like |
|
Figured out the right flag syntax. Running Bazel with It's still just a thin wrapper around Interestingly disabling built-in Java rules also breaks On the bright side, @UebelAndre would you be OK with new releases of |
@jmillikin It's really your call but the way the incompatibility flags are implemented means that all consumers of the rules are gonna be forced to leave this one off and all module maintainers are gonna be forced to deal with the error showing up in their builds. I think it'd be better to add |
|
@jmillikin friendly ping here |
|
Sorry for the delay, ran into an unexpected complication in a separate I'm going to be cutting two releases of each of the three projects, with the I'm going to do the same for For |
|
Fixes for the various issues in this PR have been applied, and are available in release v0.3.2 (most of the fixes) and v0.4 (the switch to rules_flex@0.3.2 Thank you for the PR! |
This accounts for incompatible_disable_starlark_host_transitions and incompatible_autoload_externally.