Skip to content

Conversation

@cavanaug
Copy link
Contributor

This fixes the reported problems from PR#9

@cavanaug
Copy link
Contributor Author

cavanaug commented Jun 2, 2025

It seems something has changed with the test automation infrastructure. Its not showing the pytest-asyncio module as present which is causing tests to fail. That dependency is listed in the pyproject. So Im a little confused as to what is happening.

@jmdaly
Copy link
Owner

jmdaly commented Jun 3, 2025

Thanks for this fix! That's weird about the pytest-asyncio module. Let me have a look and see what I can find!

@cavanaug
Copy link
Contributor Author

cavanaug commented Jun 3, 2025

FYI. It seems that a new version 8.4.0 of pytest was recently released. In the release notes it explicitly calls out a breaking change that causes async tests to fail.

In your workflow/test.yml you need to modify
from: pip install flake8 pytest
to: pip install flake8 pytest pytest-asyncio

@jmdaly
Copy link
Owner

jmdaly commented Jun 3, 2025

Ahh, good catch! Thanks for letting me know :) I can make the change and merge to main, then have you rebase on top of that. Will try to do that today or tomorrow. Alternatively, if you get to it before me, feel free to make that change on this branch and we can kick the build pipeline off to see if that solves it!

@cavanaug
Copy link
Contributor Author

cavanaug commented Jun 4, 2025

In the end, I just refactored the test that was using async. It was an AI added test that was getting skipped. So it was superfluous.

@jmdaly
Copy link
Owner

jmdaly commented Jun 4, 2025

This looks great, thanks for doing this!

@jmdaly jmdaly merged commit 812ee1b into jmdaly:main Jun 4, 2025
5 checks passed
@cavanaug cavanaug deleted the fix_keys branch June 4, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants