-
Notifications
You must be signed in to change notification settings - Fork 6
Fix issues with keys (set_key, del_key) as well as the authentication #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems something has changed with the test automation infrastructure. Its not showing the pytest-asyncio module as present which is causing tests to fail. That dependency is listed in the pyproject. So Im a little confused as to what is happening. |
|
Thanks for this fix! That's weird about the |
|
FYI. It seems that a new version 8.4.0 of pytest was recently released. In the release notes it explicitly calls out a breaking change that causes async tests to fail. In your workflow/test.yml you need to modify |
|
Ahh, good catch! Thanks for letting me know :) I can make the change and merge to main, then have you rebase on top of that. Will try to do that today or tomorrow. Alternatively, if you get to it before me, feel free to make that change on this branch and we can kick the build pipeline off to see if that solves it! |
|
In the end, I just refactored the test that was using async. It was an AI added test that was getting skipped. So it was superfluous. |
|
This looks great, thanks for doing this! |
This fixes the reported problems from PR#9