Fix the importing and exporting of viewing keys on mainnet + testnet#688
Merged
Fix the importing and exporting of viewing keys on mainnet + testnet#688
Conversation
Author
|
This fixes #687 |
This was referenced Jun 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that
ZCVIEWING_KEYwas only defined on regtest, and that it not being defined on mainnet/testnet was not detected. Implicitly "the empty prefix" was used, which lead to viewing keys without the normal "ZiVK" prefix which were not of the expected size, which finally fails this size check in base58.cpp :This shows a viewing key being successfully exported on one machine and imported on another, both machines running this branch:
The
ismine: falseabove means that the address had a viewing key imported.