Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding optional parameter for confirmation/notarization wait on channel open. If it is set to 0 (disabled) channelspayment could be issued right away after channelsopen is mined. Setting to 1 it will set it to default (101 confirmations or notarization). If it is set to X then it will wait X confirmations or notarization. Unspecified will default to 1.
Additiona rpc for generating secret for payment amount with which offline payments can be done by sending secret to destination party and they can verify that channelspayment can be done with that secret. Destination can broadcast channelspayment when desired, but it should be done before channelsrefund. Channelsclose tx is a signal for destination that channel will be closed and it should broadcast all pending payments before refund can be issued.