Skip to content

Fixed issues #656 & #657#658

Merged
jknack merged 5 commits intojknack:masterfrom
swjain:master
Oct 27, 2018
Merged

Fixed issues #656 & #657#658
jknack merged 5 commits intojknack:masterfrom
swjain:master

Conversation

@swjain
Copy link
Contributor

@swjain swjain commented Oct 25, 2018

Fixing grammar for ID token to accept unicode ctrl characters in the range of \u0001 - \u001F

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #658 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #658      +/-   ##
============================================
+ Coverage     87.28%   87.32%   +0.03%     
- Complexity      833      835       +2     
============================================
  Files            78       78              
  Lines          2989     2998       +9     
  Branches        407      408       +1     
============================================
+ Hits           2609     2618       +9     
  Misses          260      260              
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
...knack/handlebars/helper/DefaultHelperRegistry.java 76.63% <100%> (+2.14%) 22 <3> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b702a4...72127ae. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 25, 2018

Coverage Status

Coverage increased (+0.03%) to 91.328% when pulling 72127ae on swjain:master into 3b702a4 on jknack:master.

@swjain swjain changed the title Fixing grammar for ID token to accept unicode ctrl characters in the … Issue #656 Fixing grammar for ID token to accept unicode ctrl characters in the range of \u0001 - \u001F Oct 25, 2018
@swjain swjain changed the title Issue #656 Fixing grammar for ID token to accept unicode ctrl characters in the range of \u0001 - \u001F Fix for issue #656 & #657 Oct 26, 2018
@swjain swjain changed the title Fix for issue #656 & #657 Fixed issues #656 & #657 Oct 26, 2018
@jknack jknack added this to the 4.1.1 milestone Oct 26, 2018
@jknack
Copy link
Owner

jknack commented Oct 26, 2018

Looks good, but travis isn't happy (probably checkstyle issue)

@swjain
Copy link
Contributor Author

swjain commented Oct 26, 2018

@jknack
Is there any ETA for other issues in milestone 4.1.1? Or otherwise, would it be possible to get an early release with these fixes?

@jknack
Copy link
Owner

jknack commented Oct 26, 2018

Going to try to publish within one week (next week). Cool?

@swjain
Copy link
Contributor Author

swjain commented Oct 26, 2018

I have some deadlines to meet (max by next Tuesday). I could release a label from my forked version but wanted to go through the correct release channel. If possible, please try publishing 4.1.1 with fixes for only these two issues, otherwise will try to manage.

@jknack
Copy link
Owner

jknack commented Oct 26, 2018

Understand, will try to publish Sunday/Monday then

@swjain
Copy link
Contributor Author

swjain commented Oct 26, 2018

Thanks much!
It's a great library btw 👍 Starred :)

@jknack jknack merged commit 94f392d into jknack:master Oct 27, 2018
@jknack
Copy link
Owner

jknack commented Oct 29, 2018

Released. https://github.com/jknack/handlebars.java/releases/tag/v4.1.1

@swjain
Copy link
Contributor Author

swjain commented Oct 29, 2018

Hey @jknack,
Artifact isn't available at mvn central repo. https://mvnrepository.com/artifact/com.github.jknack/handlebars
Do you know how much time does it take?

@jknack
Copy link
Owner

jknack commented Oct 29, 2018

It is http://central.maven.org/maven2/com/github/jknack/handlebars/4.1.1/

mvnrepository takes a bit longer to sync

@swjain
Copy link
Contributor Author

swjain commented Oct 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants