Merged
Conversation
Fix "index out of bounds" exception when calling `chain.format(o)` in Formatter implementation.
Owner
|
Looks good, but checkstyle isn't happy :) |
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
============================================
+ Coverage 87.28% 87.29% +<.01%
- Complexity 833 834 +1
============================================
Files 78 78
Lines 2989 2991 +2
Branches 407 407
============================================
+ Hits 2609 2611 +2
Misses 260 260
Partials 120 120
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "index out of bounds" exception when calling
chain.format(o)in Formatter implementation.The next-method doesn't check the size of the formatter list at the moment.
This change just returns Formatter.NOOP when the end of the list is reached.