Skip to content

Inline partials "leak" - another scenario #539

@dudabone

Description

@dudabone

Hi @jknack. Thanks for the fix of issue #523, it indeed resolved the scenario I have described. However, I ran into a different scenario in which this issue still happens. This time we have two inline partials, in the second we call another template. Setup is as follows:

main.hbs:

main has partials:<br>
-------------<br>
{{>inherit1}}
-------------<br>
{{>inherit2}}

with the following partials:

base.hbs:

text from base partial<br>
{{#>inlinePartial}}{{/inlinePartial}}<br>
{{#>inlinePartial2}}{{/inlinePartial2}}<br>

inherit1.hbs:

inherit1<br>
{{#>base}}
{{#*inline "inlinePartial"}}
    inline partial defined by inherit1, called from base
{{/inline}}
    {{#*inline "inlinePartial2"}}
        {{>some-other-template}}
    {{/inline}}
{{/base}}

inherit2.hbs:

inherit2<br>
{{#>base}}
{{/base}}

some-other-template.hbs:

template called from second inline partial of inherit 1

The expected result is:

main has partials:

inherit1
text from base partial
inline partial defined by inherit1, called from base
template called from second inline partial of inherit 1

inherit2
text from base partial

Actual result:

main has partials:

inherit1
text from base partial
inline partial defined by inherit1, called from base
template called from second inline partial of inherit 1

inherit2
text from base partial
inline partial defined by inherit1, called from base

Again, the line "inline partial defined by inherit1, called from base" has "leaked" from inherit1.hbs to inherit2.hbs. I will continue trying to debug the code by myself but I can't promise anything :) as I am not yet completely familiar with the project's code. Will be great if you could take a look.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions