Merged
Conversation
added 2 commits
December 16, 2022 11:28
3 tasks
Owner
|
Merged into v0.2.1 Thanks for your contribution, appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to get schema information out of Vitess schema information using this library. Vitess is a sharding system from Youtube written in Go.
Since Vitess is MySQL under the hood and supports the MySQL dialect I figured it would work. However the error I got suggested this library did not recognize the vitess driver. Understandable. So I simply added it to the driverDialect map with a reference to the mysql dialect and it worked fine after that.
Would love to contribute this small change back since it might help someone else. One could imagine adding a whole dialect for getting more vitess specific information also, but that might be another day.
For reference: https://vitess.io/