Merged
Conversation
59c8b9d to
464255c
Compare
hipstersmoothie
commented
Sep 2, 2024
Comment on lines
+87
to
+90
| if (isWebWorker && typeof bufferOrUrl === "string") { | ||
| const res = await fetch(bufferOrUrl); | ||
| const text = await res.text(); |
Collaborator
Author
There was a problem hiding this comment.
The library we use to parse font docs doesn't support workers. This should work in most ends
464255c to
e67e39e
Compare
Collaborator
Author
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1286
closes #602 (by documenting how to use in worker)