Update image and disable image default features#30
Merged
jihchi merged 4 commits intojihchi:mainfrom Oct 4, 2024
Merged
Conversation
c2ae130 to
5f53e0b
Compare
jihchi
approved these changes
Oct 4, 2024
Owner
jihchi
left a comment
There was a problem hiding this comment.
Thank you for the contribution! The tests/e2e.rs looks better now! :chef-kiss:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR updates the image crate to 0.25 and disables image default features, so that you don't need to compile all image formats if you use dify as a library. I've added a default feature to dify that enables the image default features, so for users that install dify via
cargo install dify, nothing should change.I had to update a couple of test fixtures, I guess because the encoding of the image crate changed slightly. Also seems like the tests now behave identical in ci and locally, so I was able to remove those extra ci fixtures.