Add support for Rate Limits to Project Keys#2
Merged
jianyuan merged 3 commits intojianyuan:masterfrom Nov 7, 2019
Merged
Conversation
This was referenced Apr 8, 2019
Contributor
|
This feature would be very helpful for me as well. |
|
@jianyuan any chance we can get this merged? |
This was referenced Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, rate limits are returned when reading the keys, but they can not be set when creating / updating the keys. The API supports setting rate limits during update, and I've created an issue for support during creation.
I'd like to add this so that I can manage rate limits via terraform. I'll create a PR for the terraform provider if you're happy with this one. Changes are ready to go: Add rate limit support to terraform provider
See here for more details on the create operation: getsentry/sentry#12657