Skip to content

OpenDocument writer: New table cell support with column spans#6682

Merged
jgm merged 1 commit intojgm:masterfrom
pyssling:master
Sep 24, 2020
Merged

OpenDocument writer: New table cell support with column spans#6682
jgm merged 1 commit intojgm:masterfrom
pyssling:master

Conversation

@pyssling
Copy link
Contributor

No description provided.

@jgm
Copy link
Owner

jgm commented Sep 13, 2020

You may want to consider using the new Text.Pandoc.Writers.AnnotatedTable.
I know that this was needed to get things write for the HTML writer. (The main issue, as I recall, is accurately discerning column alignments when you have colspans and rowspans.)
See discussion at #6644
I'm not sure if this affects OpenDocument, but since it's an XML format I thought the same issue may arise.

@pyssling
Copy link
Contributor Author

@jgm I can have a look - but this really doesn't implement rowspans yet and I would prefer to tackle that separately as the need arises if that's ok. I think this is at least a step forward compared to the current state of things.

@jgm
Copy link
Owner

jgm commented Sep 13, 2020

Yes, I think the problem that module solves only emerges if you have rowspans.

But if you use that module now, it would make the path to supporting rowspans in the future much easier.

Unit tests only verify column spans at this point.
@pyssling
Copy link
Contributor Author

@jgm I've updated the code to use the Annotated table and also implemented row spans. I think it should be good to go now.

@jgm
Copy link
Owner

jgm commented Sep 24, 2020

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants